Conversation
Collaborator
Author
|
Deployment is failing as terriamap needs MSW as a dependency to build terriajs |
zoran995
force-pushed
the
test-async-function
branch
from
e1d6ae2 to
f69e364
Compare
zoran995
force-pushed
the
msw-poc
branch
2 times, most recently
from
200b0c0 to
6008b20
Compare
ljowen
approved these changes
Mar 2, 2026
Contributor
ljowen
left a comment
ljowen
left a comment
There was a problem hiding this comment.
Was able to run the tests locally :) , 2 minor comments
Contributor
There was a problem hiding this comment.
Do we need to ensure this doesn't get bundled in production builds? I guess that belongs on the TerriaMap side: copy-terriajs-assets
Collaborator
Author
There was a problem hiding this comment.
We should, but we already copied the third_party directory, which is only used for testing. It might be better to look into this separately after we see if we can figure out how to bundle terriajs as a library and not depend on the TerriaMap build process.
zoran995
force-pushed
the
test-async-function
branch
from
fe0dae4 to
68e0cd1
Compare
zoran995
force-pushed
the
test-async-function
branch
2 times, most recently
from
cc713e6 to
30f5eaa
Compare
Set up Mock Service Worker (msw) to intercept network requests at the Service Worker level, enabling gradual migration away from jasmine-ajax. Includes global Cesium Ion terrain handlers to prevent unhandled rejections from terrain loading.
…x to MSW Replace jasmine.Ajax.install/uninstall/stubRequest with MSW worker.use(http.get(...)) handlers. Removes afterEach cleanup since worker.resetHandlers() in SpecMain handles it globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Part of #7768
Introduces Mock Service Worker (MSW) as the HTTP mocking layer and migrates a first batch of specs from jasmine-ajax to MSW handlers.
See #7766 - Add ADR for replacing jasmine-ajax with MSW for more details
Test me
Run the Karma test suite — all migrated specs should pass with MSW intercepting requests instead of jasmine-ajax.
Checklist
doc/.