Open
Conversation
ljowen
reviewed
Apr 9, 2026
ljowen
reviewed
Apr 9, 2026
|
|
||
| this.appName = this.configParameters.appName ?? this.appName; | ||
| this.supportEmail = this.configParameters.supportEmail ?? this.supportEmail; | ||
| applyConfig(config: Partial<ConfigParameters>): void { |
Contributor
There was a problem hiding this comment.
Given this is a potentially breaking change (i.e. Maps could be calling terria.updateParameters() directly should this be part of a major release? I couldn't find examples in our own map repos though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #
Extract config parameters from the Terria class and create an observable data store.
Test me
Ensure that all existing parameters are available in the new store.
Checklist
doc/.