Draft
Conversation
add diff mode support
Owner
|
Hmm, this would require a major version bump |
Contributor
Author
|
@TerryHowe are you sure this would require a major version bump? All parameters are aliased so it should be backwards compatible. And the use_pre111_group_cn_behavior and description were never in hvac for as far as i can see. |
Owner
|
Might be easiest to change this module to use one parameter like "configuration" and remove the dependency on the underlying implementation although this would have lest validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: requires this pr to be merged first:
Add support for diff mode.
Renamed and added aliases to match vault api and HVAC names.
Ordered documentation and parameters to prevent missing or duplicate parameters.
removed unsupported parameter "description"
ignore "use_pre111_group_cn_behavior" in read since it is undocumented and unsupported by HVAC.
add new parameters: