Skip to content

Conversation

@Kcruz28
Copy link
Contributor

@Kcruz28 Kcruz28 commented Dec 17, 2025

No description provided.

@Kcruz28 Kcruz28 force-pushed the add-strimzi-and-gateway branch 2 times, most recently from e853074 to 099f40f Compare December 17, 2025 04:47
@Kcruz28 Kcruz28 force-pushed the add-strimzi-and-gateway branch from 099f40f to 53f7502 Compare December 17, 2025 04:49
"https://github.com/spring-cloud/spring-cloud-gcp": "unforked",
"https://github.com/spring-cloud/spring-cloud-kubernetes": "unforked",
"https://github.com/spring-cloud/spring-cloud-netflix": "unforked",
"https://github.com/spring-cloud/spring-cloud-consul": "unforked",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not delete this line as it's needed for another project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because I thought it was a duplicate. I’ll put it back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right that it's a duplicate. Sorry I didn't notice it before.

Could you change, in an hour, the checker to check that these projects are sorted and have no duplicates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i can check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forked-projects.json does not have any duplicates it is all good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it sorted? More importantly, it's not about manually checking once, but can you update format_checker/forked_projects_util.py to automatically check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok ill check it out

@darko-marinov darko-marinov merged commit 51574f4 into TestingResearchIllinois:main Dec 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants