finish reversealphabetical run order and test #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglam
reviewed
Mar 31, 2021
Comment on lines
+138
to
+145
| if ( ! className2.equals( className1 ) ) | ||
| { | ||
| return className2.compareTo( className1 ); | ||
| } | ||
| else | ||
| { | ||
| return testName2.compareTo( testName1 ); | ||
| } |
There was a problem hiding this comment.
Reduce duplication of code before this if/else block. You can move this if/else block to be lower and then just check for RunOrder.TESTORDER vs. RunOrder.REVERSEALPHEBETICAL at the necessary location
There was a problem hiding this comment.
All reversealphabetical changes should be kept in this branch and another branch and pull request should be created to not have any reverse alphabetical related changes but still have new tests for TESTORDER
|
|
||
| } | ||
|
|
||
| public void reverseAlphabeticalRunOrderTestClasses() |
There was a problem hiding this comment.
Names of these tests are invalid, They must start with "test" for JUnit 3 to find and run them
There was a problem hiding this comment.
In your new branch, repurpose all reversealphabetical tests to become TESTORDER tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.