Skip to content

Adding and increasing mspm33 twister coverage#19

Draft
Aman-Lachhiramka-ti wants to merge 101 commits intodev_mspm33from
feature/mspm33-twister-adc-coverage
Draft

Adding and increasing mspm33 twister coverage#19
Aman-Lachhiramka-ti wants to merge 101 commits intodev_mspm33from
feature/mspm33-twister-adc-coverage

Conversation

@Aman-Lachhiramka-ti
Copy link
Collaborator

This is a draft PR for reference of the work done to add twister support and Coverage flag parameter tools which come along with zephyr and twister.

padmaraghunathan90 and others added 30 commits November 7, 2025 18:01
…on_workflow

workflow: Basic build automation workflow for MSPM33
Adds relevant SOC defines for MSPM0G51xx family.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Includes devices tree files for MSPM0G51xx family.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Adds dts, yaml, and support files for the MSPM0G5187 launchpad.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
UART on the MSPM0G51xx family is part of a singular
comm peripheral (UNICOMM). Functionality is the same but
requires additional overhead of managing the register type
and include paths.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Adds UNICOMM integration/unit testing on LP_MSPM0G5187

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Add devicetree bindings for the TI MSPM0 SPI module.

Signed-off-by: Santhosh Charles <santhosh@linumiz.com>
Signed-off-by: Jackson Farley <j-farley@ti.com>
Add support for the SPI module on TI’s MSPM0 MCUs.
The driver supports master mode transfers with configurable
frame size (4–16 bits), clock polarity/phase, bit order.

Signed-off-by: Santhosh Charles <santhosh@linumiz.com>
Signed-off-by: Jackson Farley <j-farley@ti.com>
Co-authored-by: Hans Binderup <habi@bang-olufsen.dk>
Add SPI nodes in TI MSPM0 family where the spi nodes are present.

Signed-off-by: Santhosh Charles <santhosh@linumiz.com>
Signed-off-by: Jackson Farley <j-farley@ti.com>
Adds KConfig option to select DL_UNICOMM_SPI when
using a SPI driver on a UNICOMM peripheral.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Changes existing SPI driver to be compatible with
UNICOMM peripheral. Also includes other changes
to improve functionality of driver.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Adds unicomm nodes that are compatible with
SPI to MSPM0G51xx family.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Adds basic testing for UNICOMM spi.

Signed-off-by: Dylan Philpot <d-philpot@ti.com>
Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add support for MCLKBY2 clock source in the MSPM33 platform which provides a clock at half the frequency of MCLK

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Rename UART driver from mspm0-specific to a more generic msp family name to allow reuse across MSP devices such as MSPM33. The driver functionality remains unchanged. The drivers functionallity and dts bindings remains unchanged

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Update the UART binding to use a more generic MSP family name.
Update all references of the binding in device tree files and driver code.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add UNICOMM UART nodes to the dtsi to support UART functionality
on MSPM33 devices

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Includes DTS, defconfig and pin control configuration with unicomm5_uart as console.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
west manifest now points to the latest commit of dev_mspm33 branch to incorporate latest unciomm changes

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add dynamic github context variables to use current branch name and repository URL.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Consolidate MSPM33_PERIPH_STARTUP_DELAY and MSPM0_PERIPH_STARTUP_DELAY
into a single MSP_PERIPH_STARTUP_DELAY option. Update all affected
drivers to use the common configuration.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Rename SPI driver from mspm0-specific to a more generic msp family name to prepare to prepare for supporting multiple devices in MSP family.
The driver functionality and dts bindings remain unchanged.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Renaming SPI module configuration entries from MSPM0-specific to more generic MSP naming
to align with driver unification effort.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Aman-Lachhiramka-ti and others added 26 commits February 26, 2026 07:36
Fix the Clang formatting of the i2c_msp driver

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Fix bugs and improve code quality in i2c_msp driver.
Fix timeout counter clapping, ISR target/controller routine order,
and replace static semaphores with embedded struct members

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add i2c_msp_compat to abstract MSPM0(shared I2C) and
MSPM33(Unicomm I2CC/I2CT) HAL differences behind unified
DL_I2C_* names. Update Kconfig to select correct platform.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add UNICOMM I2C nodes to the dtsi to support the I2C driver on MSPM33

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add SPDX-FileCopyrightText to MSPM0 G-series dtsi files
to fix compliance warnings.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Fix the OpenOCD target configuration file path to match the
actual file layout in the TI downstream OpenOCD used for
enabling OpenOCD for MSPM33

Signed-off-by: Tejas Garg <t-garg@ti.com>
update msp-hal_ti from dev_mspm33 branch to 1.02.00.00_ea tag
for reproducible builds.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add conditional examine-start handler and reset-end FRCACT clear
so the boot ROM jumps to flash application after 'reset run'.
Update board.cmake with pre-load halt and post-verify skip flag.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Select HAS_COVERAGE_SUPPORT in board Kconfig.
Add adc, counter, dma, spi, uart to supported peripherals list.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add lp_mspm33c321a to platform_allow. Add channel@5 to overlay
for multi-channel tests. Add board conf for coverage stack sizes.
Add error tests for differential, acq_time range, acq_time unit,
oversampling with multi-channel, and calibrate not supported.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add oversampling success-path test to exercise PPB ISR path.
Add lp_mspm33c321a_vref overlay variant for internal 2.5V VREF.
Add board conf for coverage stack sizes.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add i2c to the supported list so twister can discover and run
I2C tests for this board.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add I2C test suite targeting TLV320AIC3104 codec on the LaunchPad.
20 test cases covering basic ops, transfer API, merge buffer write
and read paths, TXFIFO ISR trigger (32-byte write), error handling,
and endurance. Board overlay adds i2c0 nodelabel for merge buffer
allocation and board conf increases stack sizes for gcov coverage.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add ti to the vendor_allow list so twister discovers this test
for TI boards like lp_mspm33c321a.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add NULL guards in port_get_direction, clear INENA on
GPIO_DISCONNECTED, and use per-pin PINCM check for accurate
input direction reporting.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Check actual TX/RX ready state instead of stale interrupt
index to avoid falsely reporting pending when no data is
available.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Use a preprocessor macro for tx_buf_size so BUILD_ASSERT can
evaluate it at compile time.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Add loopback overlay with PB20 as out-gpios and PB21 as in-gpios.
Add board conf with increased stack sizes for gcov coverage.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Enable GPIO_GET_CONFIG and GPIO_GET_DIRECTION. Increase stack
sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Increase stack sizes for gcov coverage instrumentation.

Signed-off-by: Aman Lachhiramka <a-lachhiramka@ti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants