-
Notifications
You must be signed in to change notification settings - Fork 70
TF-A: Documentation Updates and Fixes #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Improve the wording in the Getting ATF source code section along with a few grammatical fixes. Signed-off-by: Dhruva Gole <[email protected]>
ATF is no longer the recognised short hand for Trusted Firmware-A anywhere. Replace all such instances of ATF with TF-A Signed-off-by: Dhruva Gole <[email protected]>
Use the ti-fork of ATF for AM62L and for other devices move to an upstream baseline Signed-off-by: Dhruva Gole <[email protected]>
e70df3d
to
7af976e
Compare
Add some more documentation talking about the transition to SCMI from TI SCI and also add what all we now support in TF-A via the SCMI interface. Signed-off-by: Dhruva Gole <[email protected]>
Exception Level 3 (EL3). | ||
|
||
Arm Trusted Firmware (ATF) is the initial code on ARMv8-A cores for all K3 platforms. | ||
TF-A is the initial code on ARMv8-A cores for all K3 platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a lot of sections that refer to TF-A as ATF. May be a good idea to clarify the name change in the overview. At least until the name change propagates through the rest of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
* ``plat/ti/k3/common/drivers/scmi/scmi_clock.c`` - Clock control and configuration | ||
* ``plat/ti/k3/board/am62l/scmi/scmi_pd_data.h`` - Device-specific power domain definitions | ||
* ``plat/ti/k3/board/am62l/scmi/scmi_clk_data.h`` - Device-specific clock tree definitions | ||
* ``plat/ti/k3/common/drivers/scmi/plat_scmi_def.h`` - Platform SCMI definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use the :file: directive here, but I'm not sure if that matters
.. rubric:: SCMI and TI SCI | ||
|
||
The AM62Lx represents a transition in Texas Instruments' approach to system control | ||
interfaces. In older K3 devices, the Texas Instruments System Controller Interface (TI SCI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"older" might have a negative connotation, maybe use "previous"
interfaces. In older K3 devices, the Texas Instruments System Controller Interface (TI SCI) | ||
was the primary protocol used for power, clock, and resource management. SCMI now serves | ||
as a replacement for newer devices like the AM62L, offering similar functionality through | ||
an industry-standard ARM protocol. This transition is the result of not having any Device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"not having any x" feels grammatically wrong (it's probably technically fine, just has that feeling), the whole line might be better as:
This transition allowed for the removal of the dedicated Device Management (Cortex-R5F) core for AM62Lx.
Summary
This PR updates and improves the documentation related to Trusted Firmware-A (TF-A). The changes focus on standardizing terminology, fixing source code repository links, and improving overall readability.
🔄 Changes
✅ Terminology Update
🔗 Repository Link Corrections
https://github.com/TexasInstruments/arm-trusted-firmware.git
https://review.trustedfirmware.org/TF-A/trusted-firmware-a.git
📝 Grammar and Readability Improvements