fix(ReprHighlighter): highlight only standalone hex; support 0X/sign/underscores; add boundary tests #3857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Summary
Fixes false positives where ReprHighlighter highlighted embedded 0x… (e.g., 1920x1080). Tightens the regex to match standalone hex literals only, while supporting optional sign, uppercase 0X, and single underscore separators between digits.
Related issue
Fixes #3854
Regex
(?<![0-9A-Za-z_])[+-]?0[xX]0-9A-Fa-f*(?![0-9A-Za-z_])
Changes
rich/highlighter.py: updated hex branch in ReprHighlighter.
tests/test_highlighter.py: added expanded boundary cases (signs, 0X, underscores, punctuation boundaries, invalid underscores).
QA
Focused + full tests: pytest -q
Tooling: black, ruff, mypy clean on touched files
Scope
Scoped to ReprHighlighter; JSON highlighter unchanged.