avoid exposing asyncio.Future directly to api consumers #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

graingert wants to merge 3 commits into Textualize:main from graingert:avoid-exposing-futures-directly-to-consumers

graingert commented Apr 24, 2025 •

edited

Loading

This avoids exposing an 'asyncio.Future' to api consumers - instead returning an awaitable object wrapping an Event and a Result.

This should fix an issue where cancellation would result in an invalid state error
This work is needed for Feature Suggestions #3 (comment) where asyncio Futures do not work with the trio backend.

Please review the following checklist.

I didn't see any documentation for this feature outside docstrings, it's probably worth a note in the changelog

Docstrings on all new or modified functions / classes
Updated documentation
Updated CHANGELOG.md (where appropriate)

graingert added 3 commits

April 24, 2025 11:19


          avoid exposing asyncio.Future directly to api consumers

b412172


          update docstrings

8b3a3ef


          address a mypy issue

a75c042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet