Skip to content

Prevent OptionList causing excessive redraws. #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

paul-ollis
Copy link
Contributor

@paul-ollis paul-ollis commented Apr 24, 2025

A OptionList with active scrollbars causes high rate, repeated redraws and high CPU usage.

This is easily demonstrated by running:

python tests/snapshot_tests/snapshot_apps/loading.py

and observing the process in your process monitor of choice.

At least one test runs for a long time as a side effect of this issue, so this PR has the nice side effect of speeding up test runs.

  • [ n/a] Docstrings on all new or modified functions / classes
  • [ n/a] Updated documentation
  • [ x] Updated CHANGELOG.md (where appropriate)

@paul-ollis paul-ollis marked this pull request as ready for review April 24, 2025 10:35
@willmcgugan willmcgugan merged commit 0f66151 into Textualize:main Apr 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants