Fix cursor_coordinate going out of bounds into header for empty tables#6411
Open
krishraghuram wants to merge 1 commit intoTextualize:mainfrom
Open
Fix cursor_coordinate going out of bounds into header for empty tables#6411krishraghuram wants to merge 1 commit intoTextualize:mainfrom
krishraghuram wants to merge 1 commit intoTextualize:mainfrom
Conversation
Member
|
Regression test please. |
Jah-yee
pushed a commit
to Jah-yee/textual
that referenced
this pull request
Mar 13, 2026
When a DataTable is empty (no rows), pressing arrow keys could cause cursor_coordinate to become (-1, 0), highlighting the header incorrectly. Fix: Use max(0, self.row_count - 1) to ensure the upper bound is never negative, which prevents clamp() from returning -1. Closes Textualize#6411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When a
DataTableis empty (no rows or columns), pressing arrow keys could causecursor_coordinateto become(-1, 0), which corresponds to the header row. This caused the header cell to be highlighted as if it were a selected data cell.The issue was in
_clamp_cursor_coordinate:When
row_count = 0, this becomesclamp(-1, 0, -1), which returns-1, causing the issue.Fix: Ensure the maximum bound is never negative:
Steps to reproduce:
DataTableand callclear()Video: https://github.com/user-attachments/assets/45096f0a-259a-4c75-b898-eae7df5f273b