Fix links in markdown table rows added via Markdown.append#6630
Open
dobbydobap wants to merge 1 commit into
Open
Fix links in markdown table rows added via Markdown.append#6630dobbydobap wants to merge 1 commit into
dobbydobap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does: Table cells mounted by
MarkdownTableContent._update_rows(theMarkdown.appendstreaming path) were plain Static widgets, unlike theMarkdownTableCellContentscells created by compose, so links in streamed table rows showed hover styling but ignored clicks. This creates them asMarkdownTableCellContentsso link clicks postMarkdown.LinkClicked, and matchescompose's tooltip handling.Why: Fixes #6597.
How I tested it: Added a regression test that streams a table via two
appendcalls and clicks a link in an appended row, it fails without the fix and passes with it. Full suite passes locally on Windows (pytest tests/ -n 16 --dist=loadgroup,3460 passed).