fix: harden completion detection and tasks-mode completion gating#47
Open
RoeeJ wants to merge 1 commit intoTh0rgal:masterfrom
Open
fix: harden completion detection and tasks-mode completion gating#47RoeeJ wants to merge 1 commit intoTh0rgal:masterfrom
RoeeJ wants to merge 1 commit intoTh0rgal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this PR after hitting repeating false positives with Codex completion detection.
This refactors completion logic into a new completion.ts module, simplifies checkCompletion in ralph.ts, and tightens task-mode rules. Completion is now detected only when the terminal promise is the final non-empty line, and in tasks mode it’s accepted only if all subtasks are complete (with guards against identical completion/task promises).
Added focused tests for the new helpers to ensure correctness and prevent regressions.