Open
Conversation
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
…r experience Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Co-authored-by: moufmouf <1290952+moufmouf@users.noreply.github.com>
Migrate test framework from tape to vitest
* Migrate from airtap to vitest + playwright for browser testing * Add test screenshots to gitignore and remove them from git * Update CI workflow to keep browser testing optional * Fixing tests so they can run in both NodeJS and browsers * Run browser tests in CI * Upgrading to Node 20 (latest supported version)
…we need to declare it as a dependency instead of a dev-dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Converted entire JavaScript codebase to TypeScript with comprehensive type definitions and zero any types, including all test files.
Because airtap does not have proper Typescript support, I also migrated tests to Vitest.
I bumped test unit tests from Node 18 to Node 20 (oldest supported version), and modified the CI so that is runs both Node AND chromium tests.
Note: firefox tests are for now failing in CI, but working locally, I still need to understand why (though that could be part of another PR).
Most of the work was done by Copilot. I reviewed the code, tested it, and manually fine-tuned it. It's working on a test setup of a pretty large project ( https://github.com/workadventure/workadventure ).
There is no "any" type used.
What is lacking:
I'm not a fan of pushing the compiled code to the repo directly, so I still need to set up a Github action that would build, then push the compiled code to NPM (probably using semantic-release).
Before going to far, I thought I would open the "WIP" PR to gather some feedback. Is this something you would be interested to merge?