Skip to content

MSVC warnings #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prince-chrismc merged 5 commits into from
Mar 24, 2026
+5 −5
Merged

MSVC warnings #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a24f32
undo unwanted changes from #405 and #408
JurgenLB Mar 8, 2026
5119b79
Cast asInt64 result to integer_type
JurgenLB Mar 8, 2026
9b9c351
Fix double type handling for int64_type
JurgenLB Mar 8, 2026
eada5ff
unwanted change
JurgenLB Mar 8, 2026
a62d56d
Merge branch 'master' into master
prince-chrismc Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/jwt-cpp/jwt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,7 +1626,7 @@ namespace jwt {
ec = error::signature_generation_error::signinit_failed;
return {};
}
if (!EVP_DigestUpdate(ctx.get(), data.data(), static_cast<unsigned int>(data.size()))) {
if (!EVP_DigestUpdate(ctx.get(), data.data(), data.size())) {
ec = error::signature_generation_error::digestupdate_failed;
return {};
}
Expand Down Expand Up @@ -1666,7 +1666,7 @@ namespace jwt {
ec = error::signature_verification_error::verifyinit_failed;
return;
}
if (!EVP_DigestUpdate(ctx.get(), data.data(), static_cast<unsigned int>(data.size()))) {
if (!EVP_DigestUpdate(ctx.get(), data.data(), data.size())) {
ec = error::signature_verification_error::verifyupdate_failed;
return;
}
Expand Down Expand Up @@ -1985,7 +1985,7 @@ namespace jwt {
return {};
}
#endif
if (EVP_DigestUpdate(md_ctx.get(), data.data(), static_cast<unsigned int>(data.size())) != 1) {
if (EVP_DigestUpdate(md_ctx.get(), data.data(), data.size()) != 1) {
ec = error::signature_generation_error::digestupdate_failed;
return {};
}
Expand Down Expand Up @@ -2034,7 +2034,7 @@ namespace jwt {
return;
}
#endif
if (EVP_DigestUpdate(md_ctx.get(), data.data(), static_cast<unsigned int>(data.size())) != 1) {
if (EVP_DigestUpdate(md_ctx.get(), data.data(), data.size()) != 1) {
ec = error::signature_verification_error::verifyupdate_failed;
return;
}
Expand Down
2 changes: 1 addition & 1 deletion include/jwt-cpp/traits/open-source-parsers-jsoncpp/traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ namespace jwt {

static integer_type as_integer(const value_type& val) {
switch (val.type()) {
case Json::intValue: return val.asInt64();
case Json::intValue: return static_cast<integer_type>(val.asInt64());
case Json::uintValue: return static_cast<integer_type>(val.asUInt64());
default: throw std::bad_cast();
}
Expand Down
Loading