fix(zanite-equipment): Fix zanite buff calculations#857
Open
Liamth99 wants to merge 4 commits into
Open
Conversation
Author
|
OK, i also forgot about the pendant, which i've now updated now (and fixed the scaling). And i added an epsilon to the buff calculation so it still shows the +0% on a tool with full durability. So just need to fix the buff scaling and i think its done. |
Liamth99
force-pushed
the
fix/Zanite-Buff
branch
from
673940e to
fc5048a
Compare
bconlon1
added
the
status/pending-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(zanite-equipment): Fix Zanite buff calculations
Fixes Zanite tool buffs by modifying the
BLOCK_BREAK_SPEEDattribute instead ofMINING_EFFICIENCY. Also changed the modifier operation fromADD_VALUEtoADD_MULTIPLIED_TOTALto show a percentage change and simplify the calculation code. Also applied this change to the rest of the equipment for consistency.I wasnt sure on how the scaling was supposed to behave but ive set the buff to linearly interpolate between +0% and +100% (let me know what the actual intended behavior is and i'm happy to fix it). I briefly tried making the crossbow implement
ZaniteWeaponto add the tooltip, but that caused melee damage to scale with durability, so I left it out but would technically work.Heads up: This is my first time working with a Minecraft modding API (and Java), so apologies if I’ve made any incorrect assumptions on how this all works.
I agree to the Contributor License Agreement (CLA).