fix: remove Combatify support explicitly. #2819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to use special attacks if it is disabled
|
I had preferred not adding it as a compile-only library, but there's not a realistic option since it would require reflection to be able to access the necessary method and the config itself, and I would rather not add reflection if it were unnecessary. Just reading the config from the file is also not an option due to how Atlas Core handles config options. |
|
On second thought, this won't compile without Atlas Core present, so perhaps reflection is better? |
Alexandra-Myers
changed the title
|
I have decided to instead simply remove Combatify support directly, instead I will probably implement it on Combatify's end or as a compat mod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Combatify support implemented in #1993, works under its default config, however since then, there is now a config option for whether attacks should charge up to 200%. This leads to the abilities of Aether weapons not working if the user turns off charged attacks, hence this PR reverts the changes, which will be reimplemented separately on Combatify's end.
I agree to the Contributor License Agreement (CLA).