Core/Logging: restore appender flags reading #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovahlord
merged commit 27cebeb
into
The-Cataclysm-Preservation-Project:master
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
This PR restores loading/handling of
Appender.*.Flagsin the logging system.It reverts a regression introduced by commit
f95a8bfdca1d70c0098a392a07a1fa29eefc1b26where flag parsing was accidentally removed.
Appender.*.Flags(ported from upstream TrinityCore master).Issues addressed: Fixes #
Tests performed: (Does it build, tested in-game, etc)
Known issues and TODO list: