Core/Player: Fix DF quest reward weekly cap check for uncapped currencies #457
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dungeon Finder reward quests incorrectly blocked rewards for currencies with no weekly cap (e.g. Justice Points), because a weekly cap check compared earned amount to a zero cap.
This change only enforces the weekly cap when it is greater than zero and keeps existing behavior for capped currencies intact.
Tests performed: (Does it build, tested in-game, etc)
build
Tested in-game: Dungeon Finder rewards are now granted correctly.