Commit dd4fab3
fix(packaging): bundle globals and lodash too, same gap as eslint-linter-browserify
v0.1.2 traded one blank-launcher crash for another: "Cannot find module
'globals'" (esLintDiagnostics.ts:46, same orphaned-dependency shape as
eslint-linter-browserify -- imported directly, present in hoisted root
node_modules so webpack externalized it, but not declared in any
package.json in this monorepo so electron-builder's dependency pruning
never traces it into the packaged app).
Did a full sweep this time instead of fixing one crash at a time: every
bare-package require() remaining in both the renderer and main production
bundles, cross-checked against noodl-editor's actual dependency graph
(direct + transitive through @noodl/platform-electron -> platform-node,
@octokit/*, react-dom, @noodl/git). Found one more of the same shape --
lodash, used directly in projectmerger.nodeequals.js/projectmerger.diff.ts
but declared nowhere in this monorepo -- and excluded it too, since it's
likely subject to the same pruning gap even though it wasn't the one
actually observed crashing yet.
Verified: renderer bundle has zero bare requires for
eslint-linter-browserify/globals/lodash; main bundle's full require list is
entirely Node builtins or already-covered direct dependencies.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>1 parent 905666e commit dd4fab3
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
67 | 69 | | |
68 | 70 | | |
69 | 71 | | |
| |||
0 commit comments