Skip to content

Commit dd4fab3

Browse files
fix(packaging): bundle globals and lodash too, same gap as eslint-linter-browserify
v0.1.2 traded one blank-launcher crash for another: "Cannot find module 'globals'" (esLintDiagnostics.ts:46, same orphaned-dependency shape as eslint-linter-browserify -- imported directly, present in hoisted root node_modules so webpack externalized it, but not declared in any package.json in this monorepo so electron-builder's dependency pruning never traces it into the packaged app). Did a full sweep this time instead of fixing one crash at a time: every bare-package require() remaining in both the renderer and main production bundles, cross-checked against noodl-editor's actual dependency graph (direct + transitive through @noodl/platform-electron -> platform-node, @octokit/*, react-dom, @noodl/git). Found one more of the same shape -- lodash, used directly in projectmerger.nodeequals.js/projectmerger.diff.ts but declared nowhere in this monorepo -- and excluded it too, since it's likely subject to the same pruning gap even though it wasn't the one actually observed crashing yet. Verified: renderer bundle has zero bare requires for eslint-linter-browserify/globals/lodash; main bundle's full require list is entirely Node builtins or already-covered direct dependencies. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 905666e commit dd4fab3

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

packages/noodl-editor/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"author": "The Low Code Foundation <contact@thelowcodefoundation.com>",
66
"homepage": "https://thelowcodefoundation.com",
77
"license": "GPL-3.0-only",
8-
"version": "0.1.2",
8+
"version": "0.1.3",
99
"main": "src/main/main.bundle.js",
1010
"scripts": {
1111
"build": "npx ts-node -P ./tsconfig.build.json ./scripts/build.ts",
@@ -64,6 +64,8 @@
6464
"node_modules",
6565
"node_modules/dugite",
6666
"!node_modules/eslint-linter-browserify",
67+
"!node_modules/globals",
68+
"!node_modules/lodash",
6769
"!test.js",
6870
"!src/main/main.js",
6971
"!src/main/github-oauth-handler.js",

0 commit comments

Comments
 (0)