tailwind v2 migration: step-zero prerequisites#610
Merged
Conversation
- Fix flashesV2.ejs missing comma that silently dropped error flashes - Port form-state preservation from stale root signupV2.ejs into views/public/signupV2.ejs - Define empty.ejs as a real bare-shell layout (DOCTYPE + Tailwind, no nav/footer) - Remove stale root signupV2.ejs and teamV2.ejs drafts (views/public versions are canonical) Prereq for the broader Tailwind V2 migration tracked in #609. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
6 tasks
kokonut121
added a commit
that referenced
this pull request
May 8, 2026
This reverts commit 5cab3f0.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flashesV2.ejs:15missing comma that silently droppedmessages.errorflashessignupV2.ejsintoviews/public/signupV2.ejs(re-fillsign,username,yob, andagreeTOSafter a failed submit, matching theformDataalready passed bypublic.js)views/layouts/empty.ejsfrom an empty file to a real bare-shell layout (DOCTYPE + Tailwind link, no nav/footer/flashes) for use by emails, error pages, robots, and the LaTeX compiler in later batchessignupV2.ejsandteamV2.ejs—views/public/versions are the canonical, more recently updated onesPrerequisite for the broader Tailwind V2 migration tracked in #609. Without working error flashes, the per-page verification step ("submit a known-bad payload, see error flash") is unreliable.
Note on the team file
The plan in #609 said to "port the updated team roster from root
teamV2.ejsintoviews/public/teamV2.ejs" — but git history showsviews/public/teamV2.ejshas 4 newer commits (video fix 2,abt us,add schools,update descriptions) and is the up-to-date version (Devesh as President, CTO Patrick, Former Board section, video embed). The root file was the stale draft in both directions. Deleted it without porting anything back.Test plan
/signup, submit a deliberately-failing form (mismatched passwords, etc.), and confirm the username/email/YOB fields and TOS checkbox stay populated after the redirectnpm run buildruns cleanly and producespublic/css/style.cssgit ls-files | grep '^[^/]*V2.ejs$'returns nothing (no stray V2 drafts at the repo root)🤖 Generated with Claude Code