src/drt/src/global.h is very generic; rename#10611
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the header file 'global.h' to 'drt-global.h' and updates its inclusion across various source and header files in the 'drt' tool. The review feedback suggests renaming 'global.cpp' to 'drt-global.cpp' for consistency and ensuring that any references in 'CMakeLists.txt' are updated to prevent build failures.
| "src/frRegionQuery.h", | ||
| "src/gc/FlexGC.h", | ||
| "src/global.h", | ||
| "src/drt-global.h", |
There was a problem hiding this comment.
Since 'global.h' has been renamed to 'drt-global.h', please make sure to update any corresponding references in 'CMakeLists.txt' (the primary build system for OpenROAD) to prevent build failures.
| #include "db/obj/frMPin.h" | ||
| #include "db/obj/frMarker.h" | ||
| #include "db/obj/frMaster.h" | ||
| #include "drt-global.h" |
There was a problem hiding this comment.
Since 'global.h' has been renamed to 'drt-global.h', please consider renaming 'global.cpp' to 'drt-global.cpp' as well. Keeping the header and source file names consistent improves maintainability and avoids confusion.
`src/drt/src/global.h` is often used witout any prefix at all (so just included as "global.h"), which is conflicing if there happens to be e.g. `@abc` in the include path (which also has a `"global.h"`. It also makes the current cyclic dependencies to fix a bit more confusing. Rename to `drt-global.h` to have an unambiguous name. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260608-drt-global
branch
from
5844d13 to
60accdb
Compare
2 participants
src/drt/src/global.his often used witout any prefix at all (so just included as "global.h"), which is conflicing if there happens to be e.g.@abcin the include path (which also has a"global.h". It also makes the current cyclic dependencies to fix a bit more confusing.Rename to
drt-global.hto have an unambiguous name.