gui: ensure QT5 and QT6 behave the same#10613
Merged
Merged
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
maliberty
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix behavior of gui::set_display_controls
Type of Change
Impact
In Qt5
gui::set_display_controls "*" visible falseworks and sets all elements to not visiblein Qt6
gui::set_display_controls "*" visible falsematched nothing, this fixes it to match.Verification
./etc/Build.sh).