web: update web threads when openroad threads change#10614
Merged
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the WebServer initialization by removing the thread count parameter from its constructor and introducing a setThreadCount method, allowing dynamic updates via OpenRoad::setThreadCount. A review comment suggests initializing the web server's thread count with getThreadCount() immediately after instantiation to ensure it is properly synchronized if the global thread count is configured prior to creation.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
maliberty
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track thread count in web overwise it ends up being 1.
Type of Change
Impact
Enable multithreading the web
Verification
./etc/Build.sh).