Skip to content

pad: add option to mark routes as FIXED in RDL#10617

Merged
gadfort merged 3 commits into
The-OpenROAD-Project:masterfrom
gadfort:pad-fixed-rdl
Jun 9, 2026
Merged

pad: add option to mark routes as FIXED in RDL#10617
gadfort merged 3 commits into
The-OpenROAD-Project:masterfrom
gadfort:pad-fixed-rdl

Conversation

@gadfort

@gadfort gadfort commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds option to mark routes a FIXED, this ensures they will not be ripped up later.

Type of Change

  • New feature

Impact

Default behavior is unchanged, this just ensure we have the option.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort gadfort requested a review from a team as a code owner June 8, 2026 22:36
@gadfort gadfort requested a review from maliberty June 8, 2026 22:36
@github-actions github-actions Bot added the size/S label Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new -fixed option to the RDL router, allowing routed wires to be marked as fixed in the database. The changes span across the C++ implementation, SWIG interface, TCL command definitions, and documentation, along with new integration tests. The review feedback highlights a critical backward-compatibility issue: inserting the new fixed parameter in the middle of the default arguments list breaks existing callers. It is recommended to append the fixed parameter to the end of the parameter list across the C++ and SWIG interfaces, and update the corresponding TCL and internal calls. Additionally, a minor typo in the README documentation should be corrected.

Comment thread src/pad/include/pad/ICeWall.h
Comment thread src/pad/src/ICeWall.cpp
Comment thread src/pad/src/pad.i
Comment thread src/pad/src/pad.i
Comment thread src/pad/src/pad.tcl
Comment thread src/pad/README.md Outdated

@maliberty maliberty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cleanups needed but otherwise fine

@gadfort gadfort enabled auto-merge June 9, 2026 12:01
@gadfort gadfort merged commit 49a9fb0 into The-OpenROAD-Project:master Jun 9, 2026
15 of 16 checks passed
@gadfort gadfort deleted the pad-fixed-rdl branch June 9, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants