odb: Validate 3dbv region coordinate count (#10460)#10623
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces validation for 3DBV region coordinates, ensuring they are specified and contain exactly four coordinates, as polygonal regions are not yet supported. It also adds corresponding test cases to verify these validation errors. The review feedback correctly identifies a bug in the new Tcl test script where exact string matching is used on the error message, which will cause the tests to fail because the error message contains additional formatting. Using regexp to match the error ID is recommended.
There was a problem hiding this comment.
Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:
- Contribution Guide: https://openroad.readthedocs.io/en/latest/contrib/contributing.html
- Build Instructions: https://openroad.readthedocs.io/en/latest/contrib/BuildWithCMake.html
Please ensure:
- CI passes
- Code is properly formatted
- Tests are included where applicable
A maintainer will review shortly!
28db84b to
29c0137
Compare
|
Thanks for contributing. |
| - [0, 1082] No newline at end of file | ||
| - [0, 1082] | ||
|
|
There was a problem hiding this comment.
This looks like a mistakenly added whitespace.
Signed-off-by: Mohnish <kmohnishm@gmail.com>
29c0137 to
06c01f9
Compare
|
Thanks for the review @maliberty ! I have cleaned up the trailing whitespace/newlines in I also formatted the Bazel |
Summary
Enforce and validate coordinate count when parsing 3dbv regions in
DbvParser::parseRegion.coordsnode is present on a region (logsODB-0521if missing).> 4stating that polygonal regions are not yet supported.example.3dbvand golden filewrite_3dbv.3dbvok) wherefront_reglacked coordinates.example_no_coords.3dbvandexample_polygon.3dbv) to prevent future regressions.Type of Change
Impact
Attempts to load a 3dbv file containing a region with missing or polygonal coordinates will now fail immediately with a clean error message (
ODB-0521) rather than propagating uninitialized bounding boxes.Verification
./etc/Build.sh).Related Issues
Closes #10460