Implement Esc key interaction for modal/cart dismissal#24
Merged
Ngha-Boris merged 2 commits intoMay 15, 2026
Merged
Conversation
|
@bryandino673 is attempting to deploy a commit to the chojuninengu's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chojuninengu
requested changes
May 15, 2026
Member
chojuninengu
left a comment
chojuninengu
left a comment
There was a problem hiding this comment.
I already love this with the esc key, can't we improve it in such a way that if the mouse is clicked outside the bucket box, the bucket will go away, same thing the esc does?
Contributor
Author
|
Its possible |
chojuninengu
approved these changes
May 15, 2026
Member
chojuninengu
left a comment
chojuninengu
left a comment
There was a problem hiding this comment.
works seamlessly like magic
Contributor
Author
|
The changes you requested have been added |
Ngha-Boris
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.