fix: build binance-tools - pin rmcp to v0.9.1 due to SSE transport removal#78
Open
revantg wants to merge 1 commit intoThe-Swarm-Corporation:mainfrom
Open
fix: build binance-tools - pin rmcp to v0.9.1 due to SSE transport removal#78revantg wants to merge 1 commit intoThe-Swarm-Corporation:mainfrom
revantg wants to merge 1 commit intoThe-Swarm-Corporation:mainfrom
Conversation
The rust-sdk removed SSE transport support in commit eb5a7f7 (feat!: remove SSE transport support) which was released in v0.11.0. This broke the binance-tools example which depends on the transport-sse-server feature. Pinning rmcp to v0.9.1 (last version with SSE transport) fixes the build. Related: modelcontextprotocol/rust-sdk#562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix the broken build of the entire swarms-rs workspace by fixing the binance-tools example. The binance-tools package was the blocking dependency that prevented the entire workspace from building.
Root Cause: The binance-tools example uses
SseServerfromrmcp, which requires thetransport-sse-serverfeature. The upstream rust-sdk removed SSE transport support in commit eb5a7f7 (released in rmcp v0.11.0).Breaking Commit: modelcontextprotocol/rust-sdk@eb5a7f7
(Since the above commit was pushed on 2nd Dec, I imagine the build for
swarms-rsrepo has been broken since 25 days)Solution: Pin the
rmcpdependency to version 0.9.1, which is the last version that includes SSE transport support and thetransport-sse-serverfeature.Impact:
Type of Change
Related Issues
This fix addresses the build failure that occurred after the rust-sdk removed SSE transport support.
Reference: modelcontextprotocol/rust-sdk#562 (commit eb5a7f7)
Changes Made
examples/binance-tools/Cargo.tomlto pinrmcpto version 0.9.1transport-sse-serverfeatureTesting
Test Coverage
Test Details
Build output:
Performance Impact
Breaking Changes
Migration Guide
N/A
Documentation
Security
Checklist
Additional Notes
The binance-tools example uses
SseServerfrom rmcp, which requires thetransport-sse-serverfeature. This feature was removed in rmcp v0.11.0 (commit eb5a7f7 in the rust-sdk repository). By pinning to v0.9.1, we restore compatibility with the SSE transport.Workspace Impact: Since binance-tools was the only package preventing the entire swarms-rs workspace from building, fixing binance-tools unblocks the complete workspace build. This was the primary objective of this fix.
Future consideration: Migrate binance-tools to use the new transport method supported by rmcp ≥0.11.0 (streamable-http) to allow updating to the latest rmcp version.
Reviewer Notes
This is a minimal, focused fix that addresses the immediate build failure by pinning to a compatible version. The change is:
examples/binance-tools/Cargo.toml*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.