Skip to content

fix(codex-protocol): align approval and notification handling with upstream#656

Open
StanGirard wants to merge 1 commit intomainfrom
fix/codex-protocol-approval-sync
Open

fix(codex-protocol): align approval and notification handling with upstream#656
StanGirard wants to merge 1 commit intomainfrom
fix/codex-protocol-approval-sync

Conversation

@StanGirard
Copy link
Copy Markdown
Contributor

Summary

  • align Companion Codex adapter with upstream protocol changes from openai/codex
  • add support for item/permissions/requestApproval and mcpServer/elicitation/request
  • handle serverRequest/resolved to clear stale pending approvals
  • accept JSON-RPC request IDs as number | string and preserve type fidelity
  • expand handled/ignored notification coverage to match new upstream v2 events
  • update generated protocol contract snapshots and add regression tests for new request/notification paths

Why

  • Codex protocol evolved and Companion was missing newer approval + resolution flows
  • missing handling caused stale approval banners and partial compatibility with newer runtimes

Testing

  • cd web && bun run typecheck
  • cd web && bun run test -- server/codex-adapter.test.ts server/codex-protocol-contract.test.ts server/codex-protocol-drift.test.ts
  • cd . && cubic review -j (issues fixed, now empty)
  • Note: full pre-commit suite (bun run test -- --coverage) hit Vitest worker timeout flakiness in this environment

Review provenance

  • Implemented by AI agent
  • Human review: no

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
companion Ready Ready Preview, Comment May 6, 2026 7:37am

Request Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants