Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/line clipping algorithms #5580

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ShikariSohan
Copy link

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 54.50%. Comparing base (87871ef) to head (c8214e5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ava/com/thealgorithms/lineclipping/utils/Line.java 30.76% 6 Missing and 3 partials ⚠️
...va/com/thealgorithms/lineclipping/utils/Point.java 30.76% 6 Missing and 3 partials ⚠️
...om/thealgorithms/lineclipping/CohenSutherland.java 87.03% 6 Missing and 1 partial ⚠️
...va/com/thealgorithms/lineclipping/LiangBarsky.java 88.88% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5580      +/-   ##
============================================
+ Coverage     53.96%   54.50%   +0.53%     
- Complexity     3387     3429      +42     
============================================
  Files           535      539       +4     
  Lines         15429    15508      +79     
  Branches       2942     2962      +20     
============================================
+ Hits           8327     8452     +125     
+ Misses         6749     6695      -54     
- Partials        353      361       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShikariSohan ShikariSohan force-pushed the feature/line-clipping-algorithms branch 3 times, most recently from 1fab98d to 1fe32ae Compare October 5, 2024 09:08
@ShikariSohan ShikariSohan force-pushed the feature/line-clipping-algorithms branch from 1fe32ae to c8214e5 Compare October 5, 2024 09:55
@ShikariSohan ShikariSohan marked this pull request as ready for review October 5, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants