Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary checking to optimal bst #11771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivnvxd
Copy link
Contributor

@ivnvxd ivnvxd commented Oct 5, 2024

Describe your change:

The changes address potential issues with small intervals and overlapping boundaries in the current implementation of Knuth's optimization of Optimal BST algorithm.

  • Improved boundary checking in the find_optimal_binary_search_tree function
  • Added error handling for potential empty ranges with fallback to full range
  • Updated main loop to use new boundaries

Fixes #11724

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 5, 2024
Copy link

@manuelaidos123 manuelaidos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tryt to Simplify the boundary checks for r_start and r_end, by adding additional checks to prevent IndexError, and replacing print statements with a logging mechanism, and configured logging for better debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize and Test Optimal Binary Search Tree Implementation for optimal_binary_search_tree.py
2 participants