Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morris Preorder traversal #11776

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Morris Preorder traversal #11776

wants to merge 7 commits into from
+150 −0

Conversation

kuntal0901
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 5, 2024
tianyizheng02
tianyizheng02 requested changes Oct 5, 2024
View reviewed changes
data_structures/binary_tree/morris_preorder_traversal.py Outdated
Comment on lines 33 to 41
Methods:
--------
insert(value: int) -> None:
Insert a value into the binary tree following binary search tree (BST) rules.
morris_preorder_traversal() -> List[int]:
Perform preorder traversal and return list of node values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Methods:
--------
insert(value: int) -> None:
Insert a value into the binary tree following binary search tree (BST) rules.
morris_preorder_traversal() -> List[int]:
Perform preorder traversal and return list of node values.

I don't think it's necessary to specify the methods in the docstring because the methods themselves should already be documented anyway.

data_structures/binary_tree/morris_preorder_traversal.py Outdated
Comment on lines 138 to 144
Returns:
--------
List[int]:
A list of integers representing the preorder traversal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns:
--------
List[int]:
A list of integers representing the preorder traversal.
Returns:
--------
A list of integers representing the preorder traversal.

See my comment on your previous PR: #11774 (comment)

@kuntal0901
Copy link
Author

@tianyizheng02 I've implemented the changes you requested. Could you review them and let me know if there are any further adjustments needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuntal0901 @tianyizheng02