Add files via upload #11784
Add files via upload #11784
Conversation
An algorithm to find intersection between 2 lines.
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/line_intersection.py
Outdated
| @@ -0,0 +1,116 @@ | |||
| # Function to calculate determinant of a 2x2 matrix | |||
| def determinant(a: float, b: float, c: float, d: float) -> float: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/line_intersection.py, please provide doctest for the function determinant
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: d
|
|
||
|
|
||
| # Function to compute the line equation coefficients from two points | ||
| def line_coefficients(p1: list[float] | tuple, p2: list[float] | tuple) -> tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/line_intersection.py, please provide doctest for the function line_coefficients
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/line_intersection.py
Outdated
| @@ -0,0 +1,134 @@ | |||
| # Function to calculate determinant of a 2x2 matrix | |||
| def determinant(a: float, b: float, c: float, d: float) -> float: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file maths/line_intersection.py, please provide doctest for the function determinant
Please provide descriptive name for the parameter: a
Please provide descriptive name for the parameter: b
Please provide descriptive name for the parameter: c
Please provide descriptive name for the parameter: d
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
require descriptive names
Hello, it's my very first time participating in Hacktoberfest. So, please tell me if I have done anything wrong.
Describe your change:
I have developed an an algorithm to find intersection between 2 lines.
Checklist: