implement segment tree using node (new .py file in data_structures/binary_tree/segment_tree_node.py) #12707

xxx595588 · 2025-05-05T05:50:12Z

Describe your change:

[v] Add an algorithm?
Fix a bug or typo in an existing algorithm?
Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
Documentation change?

Checklist:

[v] I have read CONTRIBUTING.md.
[v] This pull request is all my own work -- I have not plagiarized.
[v] I know that pull requests will not be merged if they fail the automated tests.
[v] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[v] All new Python files are placed inside an existing directory.
[v] All filenames are in all lowercase characters with no spaces or dashes.
[v] All functions and variable names follow Python naming conventions.
[v] All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

@@ -0,0 +1,145 @@
+class Node():
+    def __init__(self, start, end):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+        self.right = None
+
+class SegmentTree():
+    def __init__(self, nums, mode='max'):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: nums

Please provide type hint for the parameter: mode

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+        # Build the tree from the input list
+        self.root = self.build(0, self.size - 1, nums)
+
+    def build(self, start, end, nums):


Please provide return type hint for the function: build. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function build

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

Please provide type hint for the parameter: nums

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+
+        return root
+
+    def max_in_range(self, start_index, end_index):


Please provide return type hint for the function: max_in_range. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function max_in_range

Please provide type hint for the parameter: start_index

Please provide type hint for the parameter: end_index

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def sum_in_range(self, start_index, end_index):


Please provide return type hint for the function: sum_in_range. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function sum_in_range

Please provide type hint for the parameter: start_index

Please provide type hint for the parameter: end_index

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def query(self, node, start_index, end_index, start, end):


Please provide return type hint for the function: query. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function query

Please provide type hint for the parameter: node

Please provide type hint for the parameter: start_index

Please provide type hint for the parameter: end_index

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+            else:
+                return (self.query(node.left, start_index, end_index, start, mid) + self.query(node.right, start_index, end_index, mid + 1, end))
+
+    def update(self, index, new_value):


Please provide return type hint for the function: update. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function update

Please provide type hint for the parameter: index

Please provide type hint for the parameter: new_value

algorithms-keeper · 2025-05-05T05:59:15Z

data_structures/binary_tree/segment_tree_node.py

+
+        self.modify(self.root, index, new_value, 0, self.size - 1)
+
+    def modify(self, node, index, new_value, start, end):


Please provide return type hint for the function: modify. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function modify

Please provide type hint for the parameter: node

Please provide type hint for the parameter: index

Please provide type hint for the parameter: new_value

Please provide type hint for the parameter: start

Please provide type hint for the parameter: end

for more information, see https://pre-commit.ci

… type

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+        # Build the tree from the input list
+        self.root = self.build(0, self.size - 1, nums)
+
+    def build(self, start: int, end: int, nums: list[int]) -> Node:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function build

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+
+        return root
+
+    def max_in_range(self, start_index: int, end_index: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function max_in_range

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def sum_in_range(self, start_index: int, end_index: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function sum_in_range

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def query(self, node: Node, start_index: int, end_index: int, start: int, end: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function query

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+                    node.left, start_index, end_index, start, mid
+                ) + self.query(node.right, start_index, end_index, mid + 1, end)
+
+    def update(self, index: int, new_value: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function update

algorithms-keeper · 2025-05-05T06:08:34Z

data_structures/binary_tree/segment_tree_node.py

+
+        self.modify(self.root, index, new_value, 0, self.size - 1)
+
+    def modify(self, node: Node, index: int, new_value: int, start: int, end: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function modify

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2025-05-05T06:17:03Z

data_structures/binary_tree/segment_tree_node.py

+        # Build the tree from the input list
+        self.root = self.build(0, self.size - 1, nums)
+
+    def build(self, start: int, end: int, nums: list[int]) -> Node:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function build

algorithms-keeper · 2025-05-05T06:17:04Z

data_structures/binary_tree/segment_tree_node.py

+
+        return root
+
+    def max_in_range(self, start_index: int, end_index: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function max_in_range

algorithms-keeper · 2025-05-05T06:17:04Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def sum_in_range(self, start_index: int, end_index: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function sum_in_range

algorithms-keeper · 2025-05-05T06:17:04Z

data_structures/binary_tree/segment_tree_node.py

+
+        return self.query(self.root, start_index, end_index, 0, self.size - 1)
+
+    def query(self, node: Node, start_index: int, end_index: int, start: int, end: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function query

algorithms-keeper · 2025-05-05T06:17:04Z

data_structures/binary_tree/segment_tree_node.py

+            else:
+                return self.query(node.left, start_index, end_index, start, mid) + self.query(node.right, start_index, end_index, mid + 1, end)
+
+    def update(self, index: int, new_value: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function update

algorithms-keeper · 2025-05-05T06:17:04Z

data_structures/binary_tree/segment_tree_node.py

+
+        self.modify(self.root, index, new_value, 0, self.size - 1)
+
+    def modify(self, node: Node, index: int, new_value: int, start: int, end: int) -> int:


As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/segment_tree_node.py, please provide doctest for the function modify

for more information, see https://pre-commit.ci

xxx595588 and others added 2 commits May 5, 2025 00:45

add new file data_structures/binary_tree/segment_tree_node.py

8ece70c

[pre-commit.ci] auto fixes from pre-commit.com hooks

321d38a

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 5, 2025

xxx595588 added 2 commits May 5, 2025 00:57

add new file data_structures/binary_tree/segment_tree_node.py fixed

4c6df26

add new file data_structures/binary_tree/segment_tree_node.py fixed

571214a

algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels May 5, 2025

algorithms-keeper bot reviewed May 5, 2025

View reviewed changes

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 5, 2025

pre-commit-ci bot and others added 3 commits May 5, 2025 06:02

[pre-commit.ci] auto fixes from pre-commit.com hooks

cd6dca2

for more information, see https://pre-commit.ci

add new file data_structures/binary_tree/segment_tree_node.py add ret…

5b892bb

… type

add new file data_structures/binary_tree/segment_tree_node.py add ret…

2ed078f

… type

algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label May 5, 2025

algorithms-keeper bot reviewed May 5, 2025

View reviewed changes

pre-commit-ci bot and others added 3 commits May 5, 2025 06:08

[pre-commit.ci] auto fixes from pre-commit.com hooks

52da8eb

for more information, see https://pre-commit.ci

add new file data_structures/binary_tree/segment_tree_node.py fixedtypo

9e39d11

add new file data_structures/binary_tree/segment_tree_node.py fixed typo

c9f21d3

algorithms-keeper bot reviewed May 5, 2025

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

cb5762c

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement segment tree using node (new .py file in data_structures/binary_tree/segment_tree_node.py) #12707

implement segment tree using node (new .py file in data_structures/binary_tree/segment_tree_node.py) #12707

xxx595588 commented May 5, 2025 •

edited

Loading

algorithms-keeper bot left a comment

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot left a comment

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

algorithms-keeper bot May 5, 2025

		@@ -0,0 +1,145 @@
		class Node():
		def __init__(self, start, end):


		return self.query(self.root, start_index, end_index, 0, self.size - 1)

		def sum_in_range(self, start_index, end_index):


		return self.query(self.root, start_index, end_index, 0, self.size - 1)

		def query(self, node, start_index, end_index, start, end):


		self.modify(self.root, index, new_value, 0, self.size - 1)

		def modify(self, node, index, new_value, start, end):


		return root

		def max_in_range(self, start_index: int, end_index: int) -> int:


		return self.query(self.root, start_index, end_index, 0, self.size - 1)

		def sum_in_range(self, start_index: int, end_index: int) -> int:


		return self.query(self.root, start_index, end_index, 0, self.size - 1)

		def query(self, node: Node, start_index: int, end_index: int, start: int, end: int) -> int:


		self.modify(self.root, index, new_value, 0, self.size - 1)

		def modify(self, node: Node, index: int, new_value: int, start: int, end: int) -> int:

implement segment tree using node (new .py file in data_structures/binary_tree/segment_tree_node.py) #12707

Are you sure you want to change the base?

implement segment tree using node (new .py file in data_structures/binary_tree/segment_tree_node.py) #12707

Conversation

xxx595588 commented May 5, 2025 • edited Loading

Describe your change:

Checklist:

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

algorithms-keeper bot May 5, 2025

Choose a reason for hiding this comment

xxx595588 commented May 5, 2025 •

edited

Loading