Skip to content

fix: zellers_congruence.py fails ruff ICN001 for all open PRs - #15553

Open
peda-cos wants to merge 1 commit into
TheAlgorithms:masterfrom
peda-cos:fix/zellers-datetime-alias
Open

peda-cos wants to merge 1 commit into
TheAlgorithms:masterfrom
peda-cos:fix/zellers-datetime-alias

Conversation

@peda-cos

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Description

Repo-wide ruff check . (uvx ruff, latest) currently reports exactly one violation, maths/zellers_congruence.py:2:8 ICN001 datetime should be imported as dt, which fails the ruff job for every currently open PR (including unrelated ones). This is the only file the job reports.

Two-line change: import datetime as dt + the single usage site at line 123. Merging restores a green ruff check . baseline for all open PRs.

How I tested

  • ruff check . repo-wide: 1 error before, 0 after.
  • python -m pytest --doctest-modules maths/zellers_congruence.py — 1 passed.

Repo-wide ruff (uvx, latest) flags maths/zellers_congruence.py:2
ICN001 and this job blocks unrelated open PRs. One usage site was
renamed accordingly; doctests unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant