Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segfaulting doctest to quantum/bb84.py for demo purposes #8841

Closed
wants to merge 5 commits into from

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Jun 26, 2023

Describe your change:

Per discussion in #8818, I'm making a PR with a doctest for an input size of 100 in quantum/bb84.py to see if it will segfault in GitHub actions.

Update: it does

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed merge conflicts Open a new PR or rebase on the latest commit labels Jun 26, 2023
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Jun 26, 2023
@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Jun 26, 2023

Fatal Python error: /home/runner/work/_temp/f21d497d-6cae-49bd-acfd-3dc4c87d955b.sh: line 1:  1859 Segmentation fault      (core dumped) pytest --ignore=quantum/q_fourier_transform.py --ignore=project_euler/ --ignore=scripts/validate_solutions.py --cov-report=term-missing:skip-covered --cov=. .
quantum/bb84.py 
Error: Process completed with exit code 139.

As expected, running the bb84 function with an input size of 100 causes Python to segfault.

@tianyizheng02 tianyizheng02 changed the title Add potentially segfaulting doctest to quantum/bb84.py for demo purposes Add segfaulting doctest to quantum/bb84.py for demo purposes Jun 26, 2023
@tianyizheng02
Copy link
Contributor Author

Closing since this isn't meant to be merged and I've already proven my point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant