Added geometric mean to averages.rs#846
Closed
Marmaa0 wants to merge 6 commits intoTheAlgorithms:masterfrom
Marmaa0:add-geometric-mean
Closed
Added geometric mean to averages.rs#846Marmaa0 wants to merge 6 commits intoTheAlgorithms:masterfrom Marmaa0:add-geometric-mean
Marmaa0 wants to merge 6 commits intoTheAlgorithms:masterfrom
Marmaa0:add-geometric-mean
Conversation
…s the previous averages. This is a core average function used in finance amongst other areas. I've added some tests to go with it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
==========================================
+ Coverage 95.44% 95.48% +0.04%
==========================================
Files 316 316
Lines 22750 22974 +224
==========================================
+ Hits 21713 21937 +224
Misses 1037 1037 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
Dec 26, 2024
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a geometric mean to the averages.rs file, whilst mean, median and mode are certainly more standard than the geometric mean, it is often used within finance, and a valuable average when confronted with sequences which have a multiplicative nature. I've tried to follow the same style as the previous averages, I'm very new to rust and programming in general so I apologise in advance if I have made some obvious or glaring errors.
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.mod.rsfile within its own folder, and in any parent folder(s).DIRECTORY.mdwith the correct link.COUNTRIBUTING.mdand my code follows its guidelines.