Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,26 @@
"version": 1,
"isRoot": true,
"tools": {
"paket": {
"version": "8.0.3",
"commands": [
"paket"
]
},
"fsharp-analyzers": {
"version": "0.11.0",
"commands": [
"fsharp-analyzers"
]
],
"rollForward": false
},
"fantomas": {
"version": "6.2.0",
"version": "7.0.1",
"commands": [
"fantomas"
]
],
"rollForward": false
},
"fsdocs-tool": {
"version": "20.0.0-alpha-018",
"commands": [
"fsdocs"
]
],
"rollForward": false
}
}
}
}
5 changes: 2 additions & 3 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"ghcr.io/devcontainers-contrib/features/starship:1": {},
// https://github.com/devcontainers/features/blob/main/src/dotnet/README.md
"ghcr.io/devcontainers/features/dotnet:2": {
"version": "8.0",
"additionalVersions": "6.0"
"version": "9.0",
"additionalVersions": "8.0"
}
},
"overrideFeatureInstallOrder": [
Expand All @@ -40,7 +40,6 @@
"ms-dotnettools.csharp",
"Ionide.Ionide-fsharp",
"tintoy.msbuild-project-tools",
"ionide.ionide-paket",
"usernamehw.errorlens",
"alefragnani.Bookmarks",
"oderwat.indent-rainbow",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
global-json-file: global.json
dotnet-version: |
8.x
6.x
9.x
# Build on mac/linux
- name: Build via Bash
if: runner.os != 'Windows'
Expand Down
560 changes: 0 additions & 560 deletions .paket/Paket.Restore.targets

This file was deleted.

1 change: 0 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"ms-dotnettools.csharp",
"Ionide.Ionide-fsharp",
"tintoy.msbuild-project-tools",
"ionide.ionide-paket",
"usernamehw.errorlens",
"alefragnani.Bookmarks",
"oderwat.indent-rainbow",
Expand Down
13 changes: 12 additions & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,22 @@
<!-- owners is not supported in MSBuild -->
<OtherFlags>$(OtherFlags) --test:GraphBasedChecking --test:ParallelIlxGen --test:ParallelOptimization </OtherFlags>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<NoWarn>$(NoWarn);FS2003; NU1903; NU1904</NoWarn>
<!-- <NoWarn>$(NoWarn);FS2003; NU1903; NU1904; NU1504</NoWarn> -->
<NoWarn>$(NoWarn);FS0057</NoWarn> <!-- Suppress warning FS0057, Resumable code -->
<NoWarn>$(NoWarn);NU5104</NoWarn> <!-- Suppress warning NU5104, A stable release of a package should not have a prerelease dependency -->
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!--
* FS3517 InlineIfLambda didn't get inlined
-->
<!-- <WarnOn>$(WarnOn);3517</WarnOn> -->


</PropertyGroup>
<PropertyGroup Condition=" '$(MSBuildProjectExtension)' == '.fsproj'">
<DisableImplicitFSharpCoreReference>True</DisableImplicitFSharpCoreReference>

<LangVersion>8.0</LangVersion>
<LangVersion Condition="'$(TargetFramework)' == 'net9.0'">9.0</LangVersion>
<Nullable Condition="'$(TargetFramework)' == 'net9.0'">enable</Nullable>
</PropertyGroup>
</Project>
4 changes: 2 additions & 2 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ See https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-director
<_DotnetFantomasOutputFile>$(BaseIntermediateOutputPath)dotnet-fantomas-msbuild-$(NETCoreSdkVersion)-$(OS)</_DotnetFantomasOutputFile>
</PropertyGroup>

<!-- Make sure that dotnet tools (including paket) are restored before restoring any project -->
<Target Name="ToolRestore" BeforeTargets="Restore;CollectPackageReferences;PaketRestore" Inputs="$(_DotnetToolManifestFile)" Outputs="$(_DotnetToolRestoreOutputFile)">
<!-- Make sure that dotnet tools are restored before restoring any project -->
<Target Name="ToolRestore" BeforeTargets="Restore;CollectPackageReferences" Inputs="$(_DotnetToolManifestFile)" Outputs="$(_DotnetToolRestoreOutputFile)">
<Exec Command="dotnet tool restore" WorkingDirectory="$(MSBuildThisFileDirectory)" StandardOutputImportance="High" StandardErrorImportance="High" />
<MakeDir Directories="$(_BuildProjBaseIntermediateOutputPath)"/>
<Touch Files="$(_DotnetToolRestoreOutputFile)" AlwaysCreate="True" ForceTouch="True" />
Expand Down
41 changes: 41 additions & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<Project>
<PropertyGroup>
<!-- Enable central package management, https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management -->
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<!-- Main Package -->
<PackageVersion Include="FSharp.Core" Version="6.0.1" NoWarn="NU1504"/>
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0"/>

<!-- Benchmarks -->
<PackageVersion Include="BenchmarkDotNet" Version="0.13.9"/>
<PackageVersion Include="Ply" Version="0.3.1"/>

<!-- Test -->
<PackageVersion Include="Expecto" Version="10.1.0" />
<PackageVersion Include="Expecto.FsCheck" Version="10.1.0" />
<PackageVersion Include="Microsoft.Bcl.TimeProvider" Version="8.0.0" />
<PackageVersion Include="TimeProviderExtensions" Version="1.0.0" />
<PackageVersion Include="YoloDev.Expecto.TestSdk" Version="0.14.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageVersion Include="FSharp.Control.TaskSeq" Version="0.4.0" />


<!-- Build -->
<PackageVersion Include="Fake.IO.FileSystem" Version="6.0.0" />
<PackageVersion Include="Fake.Core.Target" Version="6.0.0" />
<PackageVersion Include="Fake.Core.ReleaseNotes" Version="6.0.0" />
<PackageVersion Include="Fake.Core.Environment" Version="6.0.0" />
<PackageVersion Include="Fake.DotNet.Cli" Version="6.0.0" />
<PackageVersion Include="Fake.Core.Process" Version="6.0.0" />
<PackageVersion Include="Fake.DotNet.AssemblyInfoFile" Version="6.0.0" />
<PackageVersion Include="Fake.Tools.Git" Version="6.0.0" />
<PackageVersion Include="Fake.Api.GitHub" Version="6.0.0" />
<PackageVersion Include="Fake.BuildServer.GitHubActions" Version="6.0.0" />
<PackageVersion Include="Argu" Version="6.2.5" />
<PackageVersion Include="Octokit" Version="0.50.0" />
<PackageVersion Include="MSBuild.StructuredLogger" Version="2.2.243" />

</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions benchmarks/CSharpTaskBenchmarks/CSharpTaskBenchmarks.csproj
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<Import Project="..\..\.paket\Paket.Restore.targets" />

</Project>
Empty file.
5 changes: 1 addition & 4 deletions benchmarks/FSharpBenchmarks/FileWritingBenchmarks.fs
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ type FileWriteBenchmarks() =
[<BenchmarkCategory("ManyWriteFile", csharp, taskBuilder);
Benchmark(Baseline = true, OperationsPerInvoke = manyIterationsConst)>]
member x.CSharp_ManyWriteFile_TaskBuilder() =
TaskPerfCSharp
.ManyWriteFileAsync(x.manyIterations, x.bufferSize)
.GetAwaiter()
.GetResult()
TaskPerfCSharp.ManyWriteFileAsync(x.manyIterations, x.bufferSize).GetAwaiter().GetResult()

[<BenchmarkCategory("ManyWriteFile", csharp, valueTaskBuilder);
Benchmark(OperationsPerInvoke = manyIterationsConst)>]
Expand Down
4 changes: 1 addition & 3 deletions benchmarks/FSharpBenchmarks/Program.fs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ open IcedTasks.Benchmarks
let main argv =

let summary =
BenchmarkSwitcher
.FromAssembly(typeof<SyncCompletionBenchmarks>.Assembly)
.Run(argv)
BenchmarkSwitcher.FromAssembly(typeof<SyncCompletionBenchmarks>.Assembly).Run(argv)

0
6 changes: 1 addition & 5 deletions benchmarks/FSharpBenchmarks/SynchonousCompletionBenchmark.fs
Original file line number Diff line number Diff line change
Expand Up @@ -614,11 +614,7 @@ type SyncCompletionBenchmarks() =
let mutable z = 0

for i in 1 .. x.manyIterations do
z <-
TaskPerfCSharp
.CSharp_TenBindsSync_TaskBuilder_BindTask()
.GetAwaiter()
.GetResult()
z <- TaskPerfCSharp.CSharp_TenBindsSync_TaskBuilder_BindTask().GetAwaiter().GetResult()

z

Expand Down
10 changes: 5 additions & 5 deletions benchmarks/FSharpBenchmarks/benchmarks.fsproj
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
</PropertyGroup>
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Optimize>true</Optimize>
<Configuration>Release</Configuration>
<IsPackable>false</IsPackable>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)'=='Release'">
<Tailcalls>true</Tailcalls>
</PropertyGroup>
<ItemGroup>
<Compile Include="Consts.fs" />
<Compile Include="SynchonousCompletionBenchmark.fs" />
Expand All @@ -24,5 +21,8 @@
<ProjectReference Include="..\..\src\IcedTasks\IcedTasks.fsproj" />
<ProjectReference Include="..\CSharpTaskBenchmarks\CSharpTaskBenchmarks.csproj" />
</ItemGroup>
<Import Project="..\..\.paket\Paket.Restore.targets" />
<ItemGroup>
<PackageReference Include="BenchmarkDotNet" />
<PackageReference Include="Ply"/>
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion benchmarks/FSharpBenchmarks/fileWriting.ps1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dotnet run -c Release -f net8.0 -- --filter "*IcedTasks.Benchmarks.FileWriteBenchmarks*" --runtimes net6.0 net8.0
dotnet run -c Release -f net8.0 -- --filter "*IcedTasks.Benchmarks.FileWriteBenchmarks*" --runtimes net9.0 net8.0
2 changes: 0 additions & 2 deletions benchmarks/FSharpBenchmarks/paket.references

This file was deleted.

4 changes: 1 addition & 3 deletions build/build.fs
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,6 @@ let clean _ =
)
|> Shell.cleanDirs

[ "paket-files/paket.restore.cached" ]
|> Seq.iter Shell.rm

let dotnetRestore _ =
[ sln ]
Expand Down Expand Up @@ -540,7 +538,7 @@ let gitRelease _ =
Git.Staging.stageFile "" "CHANGELOG.md"
|> ignore

!! "src/**/AssemblyInfo.fs"
!!"src/**/AssemblyInfo.fs"
|> Seq.iter (
Git.Staging.stageFile ""
>> ignore
Expand Down
20 changes: 18 additions & 2 deletions build/build.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<WarnOn>3390;$(WarnOn)</WarnOn>
<IsPackable>false</IsPackable>
</PropertyGroup>
Expand All @@ -11,5 +11,21 @@
<Compile Include="Changelog.fs" />
<Compile Include="build.fs" />
</ItemGroup>
<Import Project="..\.paket\Paket.Restore.targets" />

<ItemGroup>
<PackageReference Include="Argu" />
<PackageReference Include="Fake.IO.FileSystem" />
<PackageReference Include="Fake.Core.Target" />
<PackageReference Include="Fake.Core.ReleaseNotes" />
<PackageReference Include="Fake.Core.Environment" />
<PackageReference Include="Fake.DotNet.Cli" />
<PackageReference Include="Fake.Core.Process" />
<PackageReference Include="Fake.DotNet.AssemblyInfoFile" />
<PackageReference Include="Fake.Tools.Git" />
<PackageReference Include="Fake.Api.GitHub" />
<PackageReference Include="Fake.BuildServer.GitHubActions" />
<PackageReference Include="Octokit" />
<PackageReference Include="MSBuild.StructuredLogger"/>

</ItemGroup>
</Project>
15 changes: 0 additions & 15 deletions build/paket.references

This file was deleted.

2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.100",
"version": "9.0.100",
"rollForward": "latestMinor"
}
}
45 changes: 0 additions & 45 deletions paket.dependencies

This file was deleted.

Loading