Refactor Graph to speed up compile times #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes how files reference each other so make the graph for graph based type-checking
Made each file have it's own namespace rather than share the same one, added AutoOpens file to preserve
open IcedTasksgetting you access to all the CEsBefore:
After:
Unfortunately the time savings isn't much. ~1 second on the
srcproject.Types of changes
What types of changes does your code introduce to IcedTasks?
Put an
xin the boxes that applyOh yeah moving everything into their own namespace is a binary breaking change, but anything directly compiling won't notice.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...