Refactors miniposix into a compatibility layer. #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniBlade
force-pushed
the
refactor/compat
branch
4 times, most recently
from
0821e66 to
c2167aa
Compare
Inital implementation is aimed mostly at windows. Intention is to provide layer for ports to implement missing C runtime functions going forward.
OmniBlade
force-pushed
the
refactor/compat
branch
from
c2167aa to
d7199c1
Compare
ccawley2011
reviewed
Sep 4, 2022
| #include <strings.h> | ||
|
|
||
| extern inline void explicit_bzero(void *s, size_t n); | ||
| extern inline void explicit_bzero(void* s, size_t n); |
Contributor
There was a problem hiding this comment.
It seems like only strcasecmp and strncasecmp are used, so it might be worth moving those into string.h and removing the rest of the functions in these two files.
Contributor
Author
There was a problem hiding this comment.
strcasecmp is in the posix header strings.h so assuming we were to standardise on that you would want to just include that header unconditionally in all other code that uses those functions. Since pretty much all other platforms except windows have these functions there it makes sense for this header at least to exist. I can drop the strict reproduction of the other contents of the strings.h header of course if we don't use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inital implementation is aimed mostly at windows.
Intention is to provide layer for ports to implement missing C runtime
functions going forward.