Fix keyboard handling for SDL1 #974
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Unfortunately this PR will conflict with #957 Please let me know of you want to merge that PR first, then i will refactor the code |
A lot of scancodes in SDL1 are > 256. The current code assumed in a lot of places that they are less than 256, causing eg. ctrl-key combination not to work. Also the the sdl_keymap array for translating keysyms to ascii was only suitable for SDL2.
Contributor
|
I merged the other PR first, feel free to update this PR. |
|
I have used your fix in my branch merged with main one but can't scroll map with keyboard arrows. Can you test that on your end? EDIT: Changing key numbers in .ini file fixed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of scancodes in SDL1 are > 256. The current code assumed in a lot of places that they are less than 256, causing eg. ctrl-key combination not to work.
Also the the sdl_keymap array for translating keysyms to ascii was only suitable for SDL2.