Refactor/dkn 94 dukan main screen #654
Open
+168
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekIdrees
requested review from
YoussefmSaber,
haideraljawasim and
mostafa-n3ma
as code owners
# Conflicts: # dukan_presentation/src/commonMain/kotlin/net/thechance/mena/dukan/presentation/screen/main/MainScreen.kt # dukan_presentation/src/commonMain/kotlin/net/thechance/mena/dukan/presentation/screen/main/components/bestNersetDukanSection/BestNearestDukanSection.kt # dukan_presentation/src/commonMain/kotlin/net/thechance/mena/dukan/presentation/viewModel/mainScreen/MainInteractionListener.kt # dukan_presentation/src/commonMain/kotlin/net/thechance/mena/dukan/presentation/viewModel/mainScreen/MainViewModel.kt
| ) { isConnected -> | ||
| if(!isConnected) return@AnimatedContent | ||
| LazyColumn ( | ||
| contentPadding = PaddingValues(horizontal = Theme.spacing._16) |
There was a problem hiding this comment.
EditorPickDukanItem have horizontal 16 so after add on LazyColumn total became 32 maybe we need to delete form EditorPickDukanItem
ahmedNaser7
reviewed
Nov 3, 2025
Comment on lines
+89
to
+93
| if (dukanState.status == DukanStatusUi.Approved) { | ||
| getCategories() | ||
| loadEditorPicksDukans() | ||
| loadBestNearestDukans() | ||
| } |
There was a problem hiding this comment.
getDukanState is used to update the state of the Dukan icon shape in the TopAppBar. So we get the content of Home Dukan whatever happens with the Dukan icon.
ahmedNaser7
reviewed
Nov 4, 2025
| LazyVerticalGrid( | ||
| columns = GridCells.Fixed(gridLayout.columnsCount), | ||
| contentPadding = PaddingValues(horizontal = Theme.spacing._16), | ||
| contentPadding = PaddingValues(horizontal = Theme.spacing._8), |
There was a problem hiding this comment.
the start padding in categories section is more than what expected in figma design
ElsayedMagdy122
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are made to enhance the main screen: