Skip to content

Feature/DKN-96-add-search-feature #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

Feature/DKN-96-add-search-feature #661

wants to merge 22 commits into from

Conversation

@ahmedNaser7
Copy link
Collaborator

@ahmedNaser7 ahmedNaser7 commented Nov 3, 2025 •
edited
Loading

No description provided.

@ahmedNaser7
feat(search): implement search screen and functionality
62fa3cb
@ahmedNaser7
feat(search): Add search repository
2b18f08
@ahmedNaser7
feat: add SearchViewModel to DukanViewModelModule
a1d8d5c
@ahmedNaser7
refactor(presentation): Decouple DukanCard and add image background t…
2b65ce3 
…o ProductCard
@ahmedNaser7
feat(animation): Add horizontal and vertical slide transitions
584b9a5
@ahmedNaser7
refactor(category): Update DukanCard props
f05fdcd 
Pass `name` and `imageUrl` to the `DukanCard` component instead of the entire `dukan` object.
@ahmedNaser7
feat(BaseViewModel): handle errors in paging flow
4ef29d2
@ahmedNaser7
chore: remove unused imports
39eecd4
@ahmedNaser7
feat(search): Add search screen assets and strings
3d95838
@ahmedNaser7
feat(main): Add search button navigation test
7cf851b
@ahmedNaser7
Merge branch 'refs/heads/develop' into Feature/DKN-96-add-search-feature
383989e
@ahmedNaser7
Merge branch 'develop' into Feature/DKN-96-add-search-feature
d722c1f 
# Conflicts:
#	dukan_presentation/src/commonMain/composeResources/values-ar/strings.xml
@ahmedNaser7
feat(search): Add snackbar dismiss and improve search logic
f60b15e
@ahmedNaser7
feat(search): Add stub data and snack bar dismissal
50b123b
@ahmedNaser7
feat(product): Make ProductCard clickable
ffa553a
@ahmedNaser7
chore(strings): remove unused Arabic string resources
a9e303d
@ahmedNaser7
Merge branch 'develop' into Feature/DKN-96-add-search-feature
9e1da37
@ahmedNaser7
refactor(search): Replace LoadingDukanPlaceholder with `LoadingProd…
d36f8b9 
…uctCard`
@ahmedNaser7
Merge branch 'develop' into Feature/DKN-96-add-search-feature
6b5938c 
# Conflicts:
#	dukan_presentation/src/commonMain/composeResources/values-ar/strings.xml
#	dukan_presentation/src/commonMain/composeResources/values/strings.xml
#	dukan_presentation/src/commonMain/kotlin/net/thechance/mena/dukan/presentation/screen/main/components/TopAppBar.kt
@ahmedNaser7
resolve conflicts : Apply clip modifier to TopAppBar
f0ee37d
@ahmedNaser7
feat(search): Toggle dukan favorite status
886144a
@ahmedNaser7
feat: Make SnackBar onDismiss non-nullable
2b8dc90
@ahmedNaser7 ahmedNaser7 self-assigned this Nov 3, 2025
@ahmedNaser7 ahmedNaser7 added the Dukan this PR belong to Dukan feature label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

❌ Invalid Branch Name: Feature/DKN-96-add-search-feature

Thank you for your contribution! However, the branch name does not follow our required naming convention.
This check must pass before the pull request can be merged.

Please rename your branch to match the following pattern:
<type>/<jira-key>-<short-description>

Pattern Breakdown:

  • type: One of feature, fix, refactor, test.
  • jira-key: One of IDN, DKN, CHT, FTH, TRN, WLT, followed by a hyphen and the issue number.
  • short-description: A short description of the change (e.g., add-user-login).

Examples of valid branch names:

  • feature/IDN-123-add-user-login
  • fix/TRN-45-update-payment-gateway

How to fix this:

  1. Go back to your local repository and rename the branch: 
    git branch -m Feature/DKN-96-add-search-feature <new-branch-name>
  2. Push the renamed branch to the remote repository. You may need to use force push: 
    git push origin -u <new-bottom-name> --force
  3. Please make a new PR with the updated branch.

@ahmedNaser7 ahmedNaser7 closed this Nov 3, 2025
@ahmedNaser7 ahmedNaser7 deleted the Feature/DKN-96-add-search-feature branch November 4, 2025 00:15
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

❌ Invalid Branch Name: Feature/DKN-96-add-search-feature

Thank you for your contribution! However, the branch name does not follow our required naming convention.
This check must pass before the pull request can be merged.

Please rename your branch to match the following pattern:
<type>/<jira-key>-<short-description>

Pattern Breakdown:

  • type: One of feature, fix, refactor, test.
  • jira-key: One of IDN, DKN, CHT, FTH, TRN, WLT, followed by a hyphen and the issue number.
  • short-description: A short description of the change (e.g., add-user-login).

Examples of valid branch names:

  • feature/IDN-123-add-user-login
  • fix/TRN-45-update-payment-gateway

How to fix this:

  1. Go back to your local repository and rename the branch: 
    git branch -m Feature/DKN-96-add-search-feature <new-branch-name>
  2. Push the renamed branch to the remote repository. You may need to use force push: 
    git push origin -u <new-bottom-name> --force
  3. Please make a new PR with the updated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TarekIdrees TarekIdrees Awaiting requested review from TarekIdrees TarekIdrees is a code owner

@haideraljawasim haideraljawasim Awaiting requested review from haideraljawasim haideraljawasim is a code owner

@mostafa-n3ma mostafa-n3ma Awaiting requested review from mostafa-n3ma mostafa-n3ma is a code owner

@YoussefmSaber YoussefmSaber Awaiting requested review from YoussefmSaber YoussefmSaber is a code owner

Assignees

@ahmedNaser7 ahmedNaser7

Labels

Dukan this PR belong to Dukan feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmedNaser7