Dnd5e biography support #113
Conversation
|
Are you willing to add some tests like "bio is included if boolean is set", "included bio and empty preamble is ok", "included empty bio and empty preamble is error", "empty preamble and no bio inclusion is error", or shall I? |
src/scripts/chat-message-response.js
Outdated
|
|
||
| console.log("Constructed Preamble:", preamble); | ||
|
|
||
| request = `${preamble}\n\n${request}`; |
There was a problem hiding this comment.
This way the preamble is included twice:
generateResponse calls collectChatMessages, which calls messagesOrganisedForTemplate, which prepends the preamble.
|
I can handle it. I'll take care of it tomorrow. |
…ng how conversations are handled
cyelis1224
force-pushed
the
dnd5e-Bio
branch
from
a111938 to
795a0b9
Compare
|
So I can split this out if need be, but I made a mistake and made these changes in another branch I had. (Still not the most proficient with GitHub haha) I just wanted to show I got the biography working like you requested. I just accidentally did it in another branch that I had for reworking the way conversations are handled by the LLM. -_- The sad part is, as far as I could figure out, in order to have the flags on the LLM's response we lose the ability to do the /commands like whisper and /talk. I'll split it if you don't want to include all this for now but wanted to show you the changes I had to make to get multi-user convo's working and some finer control over the LLM's instructions. |
|
I went ahead and split it, I also removed the checkbox as it felt redundant since we are checking for one the other or both now. |
had left the check box option by accident
| @@ -31,6 +31,12 @@ async function getGenerationParameters(actor) { | |||
| } | |||
| let params = {}; | |||
| params.actorName = actor.name; | |||
|
|
|||
| params.includeBiography = await actor.getFlag("unkenny", "includeBiography") || false; | |||
There was a problem hiding this comment.
Without the checkbox, this flag has become obsolete.
|
Really, this breaks /whisper and /talk? As far as I remember, /whisper is evaluatee by foundry, and thus at a completely dirferent location than /talk. I also seem to remember that the evaluation of the /talk macro was a bit hacky, but that information may be outdated or misremembered. Maybe I can have a look at the weekend. If you have any preliminary tests that you can push feel free to do so. Then we can avoid doing the work twice. |
|
Alright, I'll see what I can figure out. I saw in the issue thread for the chat window conversation we were having you said you were assuming I was a better front end dev. I highly doubt that, I work in construction and just play with JS and code as a hobby. I was one of the earlier contributors for the AboveVTT project (A VTT extension that overlays a VTT directly in dndbeyond.com) but I swapped to foundry a while back and recently started playing with making modules for Foundry. Happened across your project and thought it was interesting and was just playing around haha. |
|
Since you are a contributor now, I suggest that we merge these changes to a branch in the main repository. This will make, well, collaboration easier, as we can both have the same repository cloned locally. If it's allright with you. |
Added a checkbox to the Unkenniness Parameters so that DM can choose to include the biography section of the actors sheet in the preamble being sent to the LLM. This makes it where if the actor already has a Biography you can just add some additional instructions in the preamble to explain how the NPC should talk or behave while handling their backstory from their Bio.
This was made as a response to my feature request #111