add support for enumeration type and enumerators #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abroooo
force-pushed
the
abroooo/enumeration_type
branch
from
bd99ad3 to
cf70ab7
Compare
abroooo
force-pushed
the
abroooo/enumeration_type
branch
from
cf70ab7 to
9b2a2c7
Compare
TheDan64
requested changes
Nov 21, 2025
Owner
TheDan64
left a comment
TheDan64
left a comment
There was a problem hiding this comment.
This looks good functionally but is failing on some LLVM versions and needs to be fixed
LLVMDIBuilderCreateEnumerator was added in LLVM 9.0 => guard create_enumerator, create_enumeration_type, and test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The debug info can now create enumeration types and enumerators.
Related Issue
Implements #622
How This Has Been Tested
Added unit test to show underlying llvm api is correctly called and the module with the DI builder is valid.
Option<Breaking Changes>
Checklist