UI - Version 2 - #283
Open
mpotrykus wants to merge 2 commits into
Open
Conversation
…tartConnection failures, remove dead EffectsLibrary blur/glow code
Contributor
|
Important Review skippedToo many files! This PR contains 158 files, which is 8 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (61)
📒 Files selected for processing (175)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Nice to finally see the pull request, going to install your build on my xbox tonight! |
Collaborator
|
I haven't looked at any of this yet but I'm ok if we want to do a UI overhaul. My main thing is that the quick menu, stats, logs should stay unchanged. The streaming UX can't have any fancy animations that would risk performance issues. But it should be ok for host and settings pages. I figured out a way to get the Tracy profiler to run on Xbox so we'll be able to better analyze any performance problems especially on the slower boxes. This is the next thing I'm going to work on. Maybe it will help find some improvements in the logs which is a real performance killer now. Stats is even too much for Xbox One sometimes. |
Contributor
Author
|
@andygrundman Understood. I did redo the in-stream menu to look flashier. If it ends up being a blocker, I can remove it if we find it hinders performance. I threw anything I could reasonably think of into this for the UI and tried to keep away from any of the actual streaming work. I'd say go through whenever you have time and update with a list of changes you'd like and what you want gutted out. In the mean time, I am collecting any user feedback I can. Take your time, I will update this branch if I ever find bugs. Otherwise, I will just wait until I hear more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI - Version 2
I have been working on this UI rework for around a year, off-and-on. This is meant to be a complete overhaul of the front-end, with no changes to the back-end and stream-handling. Only a few instances of app-hardening.
I have been testing this on XSX and Xbox One for a few months, and have resolved any bugs I could find. That does not mean there will be none, but that I have exhausted what QA work I can do alone.
I am dedicated to work on any requested edits to get this merged. Feel free to ask or open any discussion. I will either defend my code or be happy to make the change.
Disclaimer: AI was used to help me write out areas. I have reviewed and rewritten most of it. I take ownership of anything you find and have reviewed it all line-by-line.
Builds
I have builds available here to test:
UI-VR2
UI-VR2-nightly
Preview
Moonlight.UWP.-.UIV2.Demo.20260729.output._1.1.mp4
Headline changes
UI/tree (Pages,Modals,Models,Styles,Utilities) with a real design system (Colors.xaml,Controls.xaml)DynamicBackgroundHost,EffectsLibrary,ImageHelpers)UI/Modals/*) replacing ad-hocContentDialogusageMLOG/MLOGF,InstallCrashHandlers, in-app log viewer)Page-level highlights
AppPageViewModel), new hamburger menuCore/connection fixes
IsConnectionTerminatedfixed to be per-instance (was global, causing state bleed)Connect()mutex + freed-hostname leak fix on reconnectGamepadVibrationwhen no handler registeredApplicationState::RemoveHostno-longer-crashes-on-not-found bug fixlibgamestream:SRWLOCKfixes concurrentgs_init()race; HTTP status codes now checked (no more caching 404s as success)