Update migrations for emoji reactions#54
Open
kescherCode wants to merge 63 commits into
Open
Conversation
Squashed, modified, and rebased from glitch-soc#2221. Co-authored-by: fef <owo@fef.moe> Co-authored-by: Jeremy Kescher <jeremy@kescher.at> Co-authored-by: neatchee <neatchee@gmail.com> Co-authored-by: Ivan Rodriguez <104603218+IRod22@users.noreply.github.com> Co-authored-by: Plastikmensch <plastikmensch@users.noreply.github.com>
This was in a previous PR. Not quite sure how it didn't carry over.
Probably worth tackling later, but for now it's not worth worrying about; some other implementations (e.g. Misskey's) look to have the same behavior anyways.
Reaction icon made by t3rminus@calamity.world
This was done to announcement reactions in 1b0cb3b. Might as well do it here too.
…r emoji reaction code
This prevents things from breaking with embeds.
…roller GHSA-gwhw-gcjx-72v8 seems to affect this as well. Let's patch that up.
…nVariationSelectors
…tamp` schema.rb used to define timestamp(6) at some point. This was fixed in e179f3b for schema.rb, but not for migrations.
Author
|
Shall I change the schema.rb to account for that migration? xD |
Owner
Most definitely. |
TheEssem
force-pushed
the
feature/emoji-reactions
branch
from
742510e to
eca8ef6
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
TheEssem
force-pushed
the
feature/emoji-reactions
branch
from
eca8ef6 to
bb75aa1
Compare
TheEssem
force-pushed
the
feature/emoji-reactions
branch
from
bb75aa1 to
6fbf975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit in PR makes the normalization migration merge StatusReactions and their Notifications that are duplicates when normalizing (see glitch-soc#2462 (comment)). This is rather long-running:
The second is an entirely new migration which simply migrates the timestamp fields to match the schema.rb change in e179f3b. (it barely takes any time to run at all)
Both changes run in production on CatCatNya~.