Make NEON an option #566
Make NEON an option #566
Conversation
some ARM platforms don't have the NEON extension, to also support those, we add a possibility to disable NEON support
| @@ -24,6 +24,7 @@ option(TCAM_BUILD_TOOLS "Build additional utilities" ON) | |||
| option(TCAM_BUILD_DOCUMENTATION "Build internal code documentation" ON) | |||
| option(TCAM_BUILD_TESTS "Build tests." OFF) | |||
| option(TCAM_BUILD_VIRTCAM "Build virtual camera backend" ON) | |||
| option(TCAM_BUILD_USE_ARM_NEON "Use ARM neon extention" ON) | |||
| @@ -136,3 +137,9 @@ if (TCAM_BUILD_GIGETOOL_ONLY) | |||
| set(TCAM_ENABLED_MODULES "tcam-gigetool") | |||
|
|
|||
| endif (TCAM_BUILD_GIGETOOL_ONLY) | |||
|
|
|||
| if (TCAM_BUILD_USE_ARM_NEON) | |||
| set(DUTILS_USE_NEON ON) | |||
There was a problem hiding this comment.
What is this variable for?
DUTILS_USE_NEON is not used anywhere else.
So if in doubt just remove it.
There was a problem hiding this comment.
You can also write:
if(TCAM_BUILD_USE_ARM_NEON)
target_link_libraries(tcamconvert
PRIVATE
dutils_img::img_filter_optimized
endif(TCAM_BUILD_USE_ARM_NEON)
Put it after the initial link_libraries and your down.
If there where multiple optional libraries that have to be collected your variable approach would be the preferable one. I consider this one optional.
|
Thanks for the merge request. May I ask which NVidia SoC you are using? |
|
@TIS-Edgar That it is an ARM64 was misinformation by me, sorry for this. I assumed, that it happens on all platforms, did not check good enough. We have some products, that use Nvidia tegra2 SOC, that we still have to support. Thank you so far for your help and enjoy the holidays. |
We use a Tegra SOC, that does not have the neon extension. By default, the library uses NEON instructions for some operation if it is built for ARM architecture. This branch adds an option to disable NEON support.
FYI, I am not so well trained with cmake, so if you have some advice to improve this, I am happy to hear them.