Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a feedback form feature to the application using an embedded Google Form, along with UI improvements to the search component and minor styling adjustments.
- Added a new feedback page with an embedded Google Form accessible via
/feedbackroute - Introduced a floating feedback button (FAB) visible across all pages
- Refactored search results display from horizontal to vertical layout with improved spacing
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/static/static.module.ts | Registered FeedbackComponent in the static module declarations |
| src/app/static/static-routing.module.ts | Added route configuration for the feedback page |
| src/app/static/home/home.component.html | Updated IRDIRC resource link to use HTTPS and new URL path |
| src/app/static/feedback/feedback.component.ts | Created component with Google Form URL sanitization |
| src/app/static/feedback/feedback.component.scss | Added styles for the feedback form container and iframe |
| src/app/static/feedback/feedback.component.html | Created template with embedded Google Form iframe |
| src/app/shared/search/search/search.component.scss | Refactored search result styles to support vertical layout with flex properties |
| src/app/shared/search/search/search.component.html | Reorganized search results to display ID below name in vertical layout |
| src/app/shared/footer/footer.component.html | Added margin class to BIH logo link |
| src/app/shared/floating-feedback/floating-feedback.component.ts | Created floating feedback button component |
| src/app/shared/floating-feedback/floating-feedback.component.scss | Styled the fixed-position floating action button |
| src/app/shared/floating-feedback/floating-feedback.component.html | Created template for Material FAB with feedback icon |
| src/app/app.module.ts | Registered FloatingFeedbackComponent and reformatted module metadata |
| src/app/app.component.html | Added floating feedback button to the main app template |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| styleUrls: ['./feedback.component.scss'] | ||
| }) | ||
| export class FeedbackComponent { | ||
| // Replace this URL with your actual Google Form embed URL |
There was a problem hiding this comment.
This TODO comment should be removed since the URL has already been replaced with an actual Google Form URL.
Suggested change
| // Replace this URL with your actual Google Form embed URL |
src/app/app.module.ts
Outdated
Comment on lines
39
to
41
| providers: [SearchService, NewsService, | ||
| { provide: MAT_TABS_CONFIG, useValue: { animationDuration: '0ms' } }, | ||
| provideHttpClient(withInterceptorsFromDi())] }) |
There was a problem hiding this comment.
The providers array formatting is inconsistent. The opening bracket and first provider are on the same line, but subsequent providers are split across multiple lines in an awkward way. Consider formatting all providers consistently, either all on separate lines or keeping related items together.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.