Modernize cmake project files #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
commented
Mar 2, 2025
ClausKlein
commented
Mar 2, 2025
CMakeLists.txt
Outdated
| # CPMAddPackage("gh:TheLartians/[email protected]") | ||
| include(cmake/PackageProject.cmake) |
There was a problem hiding this comment.
@TheLartians NOTE: The original PackageProject.cmake can not use with FILE_SET HEADERS!
ClausKlein
commented
Mar 2, 2025
ClausKlein
commented
Mar 2, 2025
ClausKlein
force-pushed
the
feature/modernize-cmake-project
branch
2 times, most recently
from
b701ada to
ae4ac1d
Compare
Fix install target Update cmake-format config file Format all cmake files. Update CPM.cmake version. Use FILE_SET HEADER to verify and install the header files. Prevent build problems caused by CPM_USE_LOCAL_PACKAGES Prevent problems with doctest if local found
ClausKlein
force-pushed
the
feature/modernize-cmake-project
branch
from
ae4ac1d to
a3bc933
Compare
ClausKlein
force-pushed
the
feature/modernize-cmake-project
branch
from
10509ba to
9547016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update most packages used
With CMake 3.23 or later, a more powerful, more convenient way of handling headers is to use file sets. A file set can associate headers with a target, and the headers can be installed along with the target in an install(TARGETS) call. No separate install(FILES) or install(DIRECTORY) call is needed. In addition, a file set provides information about whether a header is private or public, and also about the header search paths a consumer of the target must use.
Use
FILE_SET HEADERSandCMAKE_VERIFY_INTERFACE_HEADER_SETSsee too TheLartians/PackageProject.cmake#32
and TheLartians/PackageProject.cmake#31